The settlement tees up another potential fight over Trump’s taxes, which have long been a subject of controversy.